V3 update header #944
V3 update header #944
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![accesslint[bot]](https://avatars.githubusercontent.com/in/1502?s=60&v=4){kind=small}
| <Text type="labelRegular">{t("contact_us")}</Text> | ||
| </Button> | ||
| </div> | ||
| <button |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
| /> | ||
| )} | ||
| <Button size="large" type="primary" background="dark"> | ||
| <Text type="labelRegular">{t("contact_us")}</Text> |
There was a problem hiding this comment.
We should add :mailto in this button
| display: flex; | ||
| flex-direction: column; | ||
|
|
||
| @media (max-width: 1024px) { | ||
| background: var(--background-bg-dark); | ||
| background: var(--primary-bg); |
There was a problem hiding this comment.
Is this a colorvariable that we have?
| min-height: 5rem; | ||
| padding: 0rem 3rem 0rem 3rem; | ||
| border-radius: 0.75rem; | ||
| background: rgba(250, 250, 250, 0.75); |
There was a problem hiding this comment.
Replace with our global variables
There was a problem hiding this comment.
Because we have lower opacity on the background, we have no global variable for the color of the header, but I can make a new variable for the header background so we can still control it from global.css!
|
There are some bugs with AccessLint. It does not refresh after it fails, even if you already fixed the access issues. For now, you can ignore the pending check. |
The header is now updated with the new design 💫
Note:
The
contact usbutton does not have any functionality yet, it needs to be added before launch. Also, the languageswitch sometimes switches the order of the languages, I could not figure out why.And the announcement banner needs to be reworked
Desktop
Screen.Recording.2024-12-04.at.09.19.51.mov
Tablet and mobile
Screen.Recording.2024-12-04.at.09.22.13.mov
Scrolling
Screen.Recording.2024-12-04.at.09.23.54.mov
Closes #906 and #830